fix(service_registry)!: correctly handle minimum workerset size (#294)

* fix(service_registry)!: correctly handle minimum workerset size
axelarnetwork · Mar 7, 2024 · 3bdd5f4 · 3bdd5f4
1 parent da01357
commit 3bdd5f4
Show file tree

Hide file tree

Showing 4 changed files with 270 additions and 118 deletions.
diff --git a/contracts/service-registry/src/contract.rs b/contracts/service-registry/src/contract.rs
@@ -385,7 +385,7 @@ pub mod query {
             .may_load(deps.storage, &service_name)?
             .ok_or(ContractError::ServiceNotFound)?;
 
-        let workers = WORKERS_PER_CHAIN
+        let workers: Vec<_> = WORKERS_PER_CHAIN
             .prefix((&service_name, &chain_name))
             .range(deps.storage, None, None, Order::Ascending)
             .map(|res| res.and_then(|(addr, _)| WORKERS.load(deps.storage, (&service_name, &addr))))
@@ -398,7 +398,11 @@ pub mod query {
             .filter(|worker| worker.authorization_state == AuthorizationState::Authorized)
             .collect();
 
-        Ok(workers)
+        if workers.len() < service.min_num_workers.into() {
+            Err(ContractError::NotEnoughWorkers)
+        } else {
+            Ok(workers)
+        }
     }
 
     pub fn get_worker(

diff --git a/contracts/service-registry/src/error.rs b/contracts/service-registry/src/error.rs
@@ -27,4 +27,6 @@ pub enum ContractError {
     WorkerNotFound,
     #[error("invalid bonding state `{0:?}` for this operation")]
     InvalidBondingState(BondingState),
+    #[error("not enough workers")]
+    NotEnoughWorkers,
 }