refactor: change ampd finalizer variant names (#301)

* refactor: change ampd finalizer variant names

* refactor: rename ConfirmationFinalizer

* fix: address lint issue with cargo fmt

* refactor: rename RPCFinalizer

ampd/src/evm/finalizer.rs

@@ -32,31 +32,32 @@ where
     H: Into<U64>,
 {
     match finalizer_type {
-        Finalization::RPCFinalizedBlock => Box::new(EthereumFinalizer::new(rpc_client)),
-        Finalization::ConfirmationHeight => {
-            Box::new(PoWFinalizer::new(rpc_client, confirmation_height))
-        }
+        Finalization::RPCFinalizedBlock => Box::new(RPCFinalizer::new(rpc_client)),
+        Finalization::ConfirmationHeight => Box::new(ConfirmationHeightFinalizer::new(
+            rpc_client,
+            confirmation_height,
+        )),
     }
 }
 
-pub struct EthereumFinalizer<'a, C>
+pub struct RPCFinalizer<'a, C>
 where
     C: EthereumClient,
 {
     rpc_client: &'a C,
 }
 
-impl<'a, C> EthereumFinalizer<'a, C>
+impl<'a, C> RPCFinalizer<'a, C>
 where
     C: EthereumClient,
 {
     pub fn new(rpc_client: &'a C) -> Self {
-        EthereumFinalizer { rpc_client }
+        RPCFinalizer { rpc_client }
     }
 }
 
 #[async_trait]
-impl<'a, C> Finalizer for EthereumFinalizer<'a, C>
+impl<'a, C> Finalizer for RPCFinalizer<'a, C>
 where
     C: EthereumClient + Send + Sync,
 {
@@ -70,31 +71,31 @@ where
     }
 }
 
-pub struct PoWFinalizer<'a, C>
+pub struct ConfirmationHeightFinalizer<'a, C>
 where
     C: EthereumClient,
 {
     rpc_client: &'a C,
     confirmation_height: U64,
 }
 
-impl<'a, C> PoWFinalizer<'a, C>
+impl<'a, C> ConfirmationHeightFinalizer<'a, C>
 where
     C: EthereumClient,
 {
     pub fn new<H>(rpc_client: &'a C, confirmation_height: H) -> Self
     where
         H: Into<U64>,
     {
-        PoWFinalizer {
+        ConfirmationHeightFinalizer {
             rpc_client,
             confirmation_height: confirmation_height.into(),
         }
     }
 }
 
 #[async_trait]
-impl<'a, C> Finalizer for PoWFinalizer<'a, C>
+impl<'a, C> Finalizer for ConfirmationHeightFinalizer<'a, C>
 where
     C: EthereumClient + Send + Sync,
 {
@@ -111,7 +112,7 @@ where
 
 #[cfg(test)]
 mod tests {
-    use crate::evm::finalizer::{pick, Finalization, Finalizer, PoWFinalizer};
+    use crate::evm::finalizer::{pick, ConfirmationHeightFinalizer, Finalization, Finalizer};
     use crate::evm::json_rpc::MockEthereumClient;
     use ethers::{
         abi::Hash,
@@ -128,7 +129,7 @@ mod tests {
             .returning(move || Ok(block_number));
         assert_eq!(
             block_number,
-            PoWFinalizer::new(&rpc_client, 1)
+            ConfirmationHeightFinalizer::new(&rpc_client, 1)
                 .latest_finalized_block_height()
                 .await
                 .unwrap()
@@ -141,7 +142,7 @@ mod tests {
             .returning(move || Ok(block_number));
         assert_eq!(
             block_number + 1,
-            PoWFinalizer::new(&rpc_client, 0)
+            ConfirmationHeightFinalizer::new(&rpc_client, 0)
                 .latest_finalized_block_height()
                 .await
                 .unwrap()
@@ -154,7 +155,7 @@ mod tests {
             .returning(move || Ok(block_number));
         assert_eq!(
             block_number - 1,
-            PoWFinalizer::new(&rpc_client, 2)
+            ConfirmationHeightFinalizer::new(&rpc_client, 2)
                 .latest_finalized_block_height()
                 .await
                 .unwrap()
@@ -167,7 +168,7 @@ mod tests {
             .returning(move || Ok(block_number));
         assert_eq!(
             U64::from(1),
-            PoWFinalizer::new(&rpc_client, block_number)
+            ConfirmationHeightFinalizer::new(&rpc_client, block_number)
                 .latest_finalized_block_height()
                 .await
                 .unwrap()