more restricted implementation

axelarnetwork · Nov 22, 2024 · e8974cb · e8974cb
1 parent 6434f72
commit e8974cb
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 28 deletions.
diff --git a/contracts/voting-verifier/src/contract.rs b/contracts/voting-verifier/src/contract.rs
@@ -266,9 +266,8 @@ mod test {
             .to_string()
             .parse()
             .unwrap(),
-            MessageIdFormat::Bech32m => {
+            MessageIdFormat::Bech32m(prefix, _length) => {
                 let data = format!("{id}-{index}");
-                let prefix = "bech32m";
                 let hrp = Hrp::parse(prefix).expect("valid hrp");
                 bech32::encode::<Bech32m>(hrp, data.as_bytes())
                     .unwrap()

diff --git a/contracts/voting-verifier/src/events.rs b/contracts/voting-verifier/src/events.rs
@@ -186,8 +186,8 @@ fn parse_message_id(
 
             Ok((id.tx_hash_as_hex(), 0))
         }
-        MessageIdFormat::Bech32m => {
-            let bech32m_message_id = Bech32mFormat::from_str(message_id)
+        MessageIdFormat::Bech32m(prefix, length) => {
+            let bech32m_message_id = Bech32mFormat::from_str(prefix, *length, message_id)
                 .map_err(|_| ContractError::InvalidMessageID(message_id.into()))?;
             Ok((bech32m_message_id.to_string().try_into()?, 0))
         }

diff --git a/packages/axelar-wasm-std/src/msg_id/bech32m.rs b/packages/axelar-wasm-std/src/msg_id/bech32m.rs
@@ -1,10 +1,8 @@
 use std::fmt::{self, Display};
-use std::str::FromStr;
 
 use bech32::primitives::decode::CheckedHrpstring;
 use bech32::Bech32m;
-use error_stack::{bail, Report, ResultExt};
-use lazy_static::lazy_static;
+use error_stack::{bail, ensure, Report, ResultExt};
 use regex::Regex;
 
 use super::Error;
@@ -17,30 +15,27 @@ impl Bech32mFormat {
     pub fn new(encoded: String) -> Self {
         Self { encoded }
     }
-}
-
-const PATTERN: &str = "^([0-9ac-hj-np-z]{8,90})$";
 
-lazy_static! {
-    static ref REGEX: Regex = Regex::new(PATTERN).expect("invalid regex");
-}
+    pub fn from_str(prefix: &str, length: u8, message_id: &str) -> Result<Self, Report<Error>> {
+        let pattern = format!(
+            "^({}1[02-9ac-hj-np-z]{{{}}})$",
+            prefix,
+            length
+                .saturating_sub(prefix.len().try_into().unwrap())
+                .saturating_sub(1)
+        );
 
-impl FromStr for Bech32mFormat {
-    type Err = Report<Error>;
+        let regex = Regex::new(pattern.as_str()).expect("invalid regex");
 
-    fn from_str(message_id: &str) -> Result<Self, Self::Err>
-    where
-        Self: Sized,
-    {
-        let (_, [string]) = REGEX
+        let (_, [string]) = regex
             .captures(message_id)
             .ok_or(Error::InvalidMessageID {
                 id: message_id.to_string(),
-                expected_format: "Bech32m".to_string(),
+                expected_format: "Foo Bech32m".to_string(),
             })?
             .extract();
 
-        verify_bech32m(string)?;
+        verify_bech32m(string, prefix)?;
 
         Ok(Self {
             encoded: string.to_string(),
@@ -54,10 +49,17 @@ impl Display for Bech32mFormat {
     }
 }
 
-fn verify_bech32m(input: &str) -> Result<(), Report<Error>> {
+fn verify_bech32m(input: &str, expected_prefix: &str) -> Result<(), Report<Error>> {
     let checked = CheckedHrpstring::new::<Bech32m>(input)
         .change_context(Error::InvalidBech32m(input.to_string()))?;
 
+    ensure!(
+        checked.hrp().as_str() == expected_prefix,
+        Error::InvalidBech32m(format!(
+            "Expected prefix '{expected_prefix}' not found: '{input}'"
+        ))
+    );
+
     if checked.data_part_ascii_no_checksum().is_empty() {
         bail!(Error::InvalidBech32m(format!(
             "Message Id is missing the data part: '{input}'"

diff --git a/packages/axelar-wasm-std/src/msg_id/mod.rs b/packages/axelar-wasm-std/src/msg_id/mod.rs
@@ -49,7 +49,7 @@ pub enum MessageIdFormat {
     Base58TxDigestAndEventIndex,
     Base58SolanaTxSignatureAndEventIndex,
     HexTxHash,
-    Bech32m,
+    Bech32m(String, u8), // (prefix, length)
 }
 
 // function the router calls to verify msg ids
@@ -65,7 +65,7 @@ pub fn verify_msg_id(message_id: &str, format: &MessageIdFormat) -> Result<(), R
             Base58SolanaTxSignatureAndEventIndex::from_str(message_id).map(|_| ())
         }
         MessageIdFormat::HexTxHash => HexTxHash::from_str(message_id).map(|_| ()),
-        MessageIdFormat::Bech32m => Bech32mFormat::from_str(message_id).map(|_| ()),
+        MessageIdFormat::Bech32m(prefix, length) => Bech32mFormat::from_str(prefix, *length, message_id).map(|_| ()),
     }
 }
 
@@ -121,15 +121,15 @@ mod test {
     #[test]
     fn should_verify_bech32m() {
         let message_id = "at1hs0xk375g4kvw53rcem9nyjsdw5lsv94fl065n77cpt0774nsyysdecaju";
-        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m).is_ok());
+        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m("at".to_string(), 61)).is_ok());
     }
 
     #[test]
     fn should_not_verify_bech32m() {
         let message_id = "aths0xk375g4kvw53rcem9nyjsdw5lsv94fl065n77cpt0774nsyysdecaju";
-        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m).is_err());
+        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m("at".to_string(), 61)).is_err());
 
         let message_id = "ath1s0xk375g4kvw53rcem9nyjsdw5lsv94fl065n77cpt0774nsyysdecaj";
-        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m).is_err());
+        assert!(verify_msg_id(message_id, &MessageIdFormat::Bech32m("at".to_string(), 61)).is_err());
     }
 }