Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ampd): retry event handling with timeout and max attemmpts #251

Merged
merged 19 commits into from
Feb 16, 2024
Merged

feat(ampd): retry event handling with timeout and max attemmpts #251

merged 19 commits into from
Feb 16, 2024

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Feb 1, 2024 •
edited
Loading

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy marked this pull request as ready for review February 2, 2024 06:04
@fish-sammy fish-sammy requested a review from a team as a code owner February 2, 2024 06:04
@fish-sammy fish-sammy force-pushed the AXE-3035-Re-try-event-handling-with-timeout-in-ampd branch from e124d4a to 1c59803 Compare February 2, 2024 12:50
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e7a2301) 89.56% compared to head (b7712c7) 89.60%.

Files Patch % Lines
packages/events/src/event.rs 0.00% 13 Missing ⚠️
ampd/src/event_processor.rs 86.36% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   89.56%   89.60%   +0.03%     
==========================================
  Files         165      166       +1     
  Lines       17050    17170     +120     
==========================================
+ Hits        15271    15385     +114     
- Misses       1779     1785       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cjcobb23
cjcobb23 reviewed Feb 2, 2024
View reviewed changes
ampd/src/event_processor.rs Outdated Show resolved Hide resolved
ampd/src/event_processor.rs Outdated Show resolved Hide resolved
cgorenflo
cgorenflo reviewed Feb 2, 2024
View reviewed changes
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/event_processor.rs Outdated Show resolved Hide resolved
@fish-sammy fish-sammy force-pushed the AXE-3035-Re-try-event-handling-with-timeout-in-ampd branch from 0018e48 to 6346448 Compare February 6, 2024 08:22
@fish-sammy fish-sammy force-pushed the AXE-3035-Re-try-event-handling-with-timeout-in-ampd branch from 6346448 to 860759d Compare February 6, 2024 14:42
cgorenflo
cgorenflo reviewed Feb 7, 2024
View reviewed changes
ampd/src/event_processor.rs Outdated Show resolved Hide resolved
ampd/src/event_processor.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
ampd/src/asyncutil/future.rs Outdated Show resolved Hide resolved
packages/events/src/event.rs Outdated Show resolved Hide resolved
cgorenflo
cgorenflo approved these changes Feb 15, 2024
View reviewed changes
ampd/src/event_processor.rs Show resolved Hide resolved
@fish-sammy fish-sammy enabled auto-merge (squash) February 16, 2024 10:23
@fish-sammy fish-sammy merged commit 96eadd5 into main Feb 16, 2024
6 of 7 checks passed
@fish-sammy fish-sammy deleted the AXE-3035-Re-try-event-handling-with-timeout-in-ampd branch February 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 approved these changes

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fish-sammy @cgorenflo @cjcobb23