-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ampd): skip events from unknown contracts #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 89.72% 89.77% +0.04%
==========================================
Files 161 161
Lines 16653 16765 +112
==========================================
+ Hits 14942 15050 +108
- Misses 1711 1715 +4 ☔ View full report in Codecov by Sentry. |
cgorenflo
reviewed
Feb 7, 2024
fish-sammy
reviewed
Feb 12, 2024
fish-sammy
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handlers currently return an error when encountering an event with the same event_type as what they are looking for, but with different fields. This can happen due to contract upgrades, but also if any random contract emits an event with the same event_type as the event the handler cares about. This can cause either crashing the process, or unnecessary retries (and waiting).
This PR makes a change so that the handlers first check the "_contract_address" field of the event, and simply skip the event (returning
Ok(())
) if the address doesn't match the contract address for which the handler is configured to handle events.https://axelarnetwork.atlassian.net/browse/AXE-3080