Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify complexity in verify() signature implementation #287

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

eguajardo
Copy link
Contributor

@eguajardo eguajardo commented Mar 1, 2024

Description

https://axelarnetwork.atlassian.net/browse/AXE-3276

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@eguajardo eguajardo requested a review from a team as a code owner March 1, 2024 21:01
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.66%. Comparing base (aad015b) to head (41f331f).

Files Patch % Lines
contracts/multisig/src/signing.rs 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   90.61%   90.66%   +0.04%     
==========================================
  Files         161      161              
  Lines       17620    17673      +53     
==========================================
+ Hits        15967    16023      +56     
+ Misses       1653     1650       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguajardo eguajardo merged commit e120fa8 into main Mar 4, 2024
7 checks passed
@eguajardo eguajardo deleted the refactor/simplify_verify branch March 4, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants