feat(interchain-token-service): apply scaling factor on token transfer based on token decimals #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
changed the base branch from
main
to
AXE-6168-Calculate-the-scaling-factor-at-token-deployment-and-store-it-in-the-ITS-hub
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
from
4c1556e
to
905d6c9
Compare
fish-sammy
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## AXE-6168-Calculate-the-scaling-factor-at-token-deployment-and-store-it-in-the-ITS-hub #675 +/- ##
=========================================================================================================================
- Coverage 93.56% 93.52% -0.05%
=========================================================================================================================
Files 237 237
Lines 35220 35293 +73
=========================================================================================================================
+ Hits 32955 33009 +54
- Misses 2265 2284 +19 ☔ View full report in Codecov by Sentry. |
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
5 times, most recently
from
d7abd6e
to
b79e9ea
Compare
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
from
3714ab1
to
966d69b
Compare
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
from
ce2be5e
to
6637f40
Compare
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
from
6637f40
to
641cce2
Compare
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
5 times, most recently
from
0b8008f
to
f196d7a
Compare
fish-sammy
force-pushed
the
AXE-6169-Apply-the-scaling-factor-at-token-transfer
branch
from
f196d7a
to
9c6d991
Compare
cjcobb23
reviewed
Nov 3, 2024
cjcobb23
approved these changes
Nov 4, 2024
cgorenflo
reviewed
Nov 4, 2024
Comment on lines
+304
to
+342
| // It's intentionally written in this way since the end result may still be fine even if | ||
| // 1) amount * (10 ^ (dest_chain_decimals)) overflows | ||
| // 2) amount / (10 ^ (src_chain_decimals)) is zero | ||
| let scaling_factor = Uint256::from_u128(10) | ||
| .checked_pow(source_decimals.abs_diff(destination_decimals).into()) | ||
| .change_context_lazy(|| Error::InvalidTransferAmount { | ||
| source_chain: source_chain.to_owned(), | ||
| destination_chain: destination_chain.to_owned(), | ||
| amount: source_amount, | ||
| })?; | ||
| let destination_amount = if source_decimals > destination_decimals { | ||
| source_amount | ||
| .checked_div(scaling_factor) | ||
| .expect("scaling_factor must be non-zero") | ||
| } else { | ||
| source_amount | ||
| .checked_mul(scaling_factor) | ||
| .change_context_lazy(|| Error::InvalidTransferAmount { | ||
| source_chain: source_chain.to_owned(), | ||
| destination_chain: destination_chain.to_owned(), | ||
| amount: source_amount, | ||
| })? | ||
| }; | ||
|
|
||
| if destination_amount.gt(&destination_max_uint) { | ||
| bail!(Error::InvalidTransferAmount { | ||
| source_chain: source_chain.to_owned(), | ||
| destination_chain: destination_chain.to_owned(), | ||
| amount: source_amount, | ||
| }) | ||
| } | ||
|
|
||
| nonempty::Uint256::try_from(destination_amount).change_context_lazy(|| { | ||
| Error::InvalidTransferAmount { | ||
| source_chain: source_chain.to_owned(), | ||
| destination_chain: destination_chain.to_owned(), | ||
| amount: source_amount, | ||
| } | ||
| }) |
There was a problem hiding this comment.
this calculation could get extracted into it's own function
cgorenflo
approved these changes
Nov 4, 2024
fish-sammy
deleted the branch
AXE-6168-Calculate-the-scaling-factor-at-token-deployment-and-store-it-in-the-ITS-hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes