Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interchain-token-service): apply scaling factor on token transfer based on token decimals #677

Merged
merged 18 commits into from
Nov 4, 2024

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Nov 4, 2024

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner November 4, 2024 15:41
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 76.25000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (afe253d) to head (1d3b5d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/interchain-token-service/src/contract/execute.rs 75.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   93.56%   93.52%   -0.05%     
==========================================
  Files         237      237              
  Lines       35220    35293      +73     
==========================================
+ Hits        32955    33009      +54     
- Misses       2265     2284      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy merged commit d1b9ec6 into main Nov 4, 2024
7 of 8 checks passed
@fish-sammy fish-sammy deleted the AXE-6169-Apply-the-scaling-factor-at-token-transfer branch November 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants