Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor-interchain-token-service): refactor chain registration #681

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

cjcobb23
Copy link
Contributor

@cjcobb23 cjcobb23 commented Nov 5, 2024

  • combine SetChainConfig and RegisterItsContract into single message
  • add UpdateChain message

* combine SetChainConfig and RegisterItsContract into single message
* add UpdateChain message
@cjcobb23 cjcobb23 requested a review from a team as a code owner November 5, 2024 20:56
@cjcobb23 cjcobb23 marked this pull request as draft November 5, 2024 20:56
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 99.32886% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.49%. Comparing base (98acb3b) to head (79ccf56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/interchain-token-service/src/msg.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   93.50%   93.49%   -0.02%     
==========================================
  Files         237      237              
  Lines       35132    35192      +60     
==========================================
+ Hits        32851    32903      +52     
- Misses       2281     2289       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjcobb23 cjcobb23 marked this pull request as ready for review November 6, 2024 21:26
@cjcobb23 cjcobb23 enabled auto-merge (squash) November 7, 2024 17:03
@cjcobb23 cjcobb23 merged commit 08bec3c into main Nov 7, 2024
6 checks passed
@cjcobb23 cjcobb23 deleted the its_hub_chain_registration branch November 7, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants