Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interchain-token-service): create message execution interceptors #682

Merged

Conversation

fish-sammy
Copy link
Collaborator

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 97.06362% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (08bec3c) to head (f9c3e2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...token-service/src/contract/execute/interceptors.rs 96.85% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   93.49%   93.57%   +0.07%     
==========================================
  Files         237      238       +1     
  Lines       35192    35523     +331     
==========================================
+ Hits        32903    33239     +336     
+ Misses       2289     2284       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy force-pushed the refactor/interchain_token_service_message_interceptors branch from cd16132 to 0c3ffa5 Compare November 6, 2024 17:51
@fish-sammy fish-sammy marked this pull request as ready for review November 6, 2024 17:52
@fish-sammy fish-sammy requested a review from a team as a code owner November 6, 2024 17:52
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike the mutation of function arguments that's in this change, it feels like a bit of an anti pattern. I'm happy to be wrong, but would like to discuss with the team before merging. I don't think we do this anywhere else in the code.

@fish-sammy fish-sammy force-pushed the refactor/interchain_token_service_message_interceptors branch from 6529fca to 4a8c453 Compare November 8, 2024 16:53
@fish-sammy fish-sammy force-pushed the refactor/interchain_token_service_message_interceptors branch from 4049046 to f9c3e2a Compare November 8, 2024 17:07
@fish-sammy fish-sammy merged commit 6dd3b41 into main Nov 8, 2024
8 checks passed
@fish-sammy fish-sammy deleted the refactor/interchain_token_service_message_interceptors branch November 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants