-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interchain-token-service): create message execution interceptors #682
refactor(interchain-token-service): create message execution interceptors #682
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 93.49% 93.57% +0.07%
==========================================
Files 237 238 +1
Lines 35192 35523 +331
==========================================
+ Hits 32903 33239 +336
+ Misses 2289 2284 -5 ☔ View full report in Codecov by Sentry. |
cd16132
to
0c3ffa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike the mutation of function arguments that's in this change, it feels like a bit of an anti pattern. I'm happy to be wrong, but would like to discuss with the team before merging. I don't think we do this anywhere else in the code.
contracts/interchain-token-service/src/contract/execute/interceptors.rs
Outdated
Show resolved
Hide resolved
contracts/interchain-token-service/src/contract/execute/interceptors.rs
Outdated
Show resolved
Hide resolved
contracts/interchain-token-service/src/contract/execute/interceptors.rs
Outdated
Show resolved
Hide resolved
6529fca
to
4a8c453
Compare
4049046
to
f9c3e2a
Compare
Description
Todos
Steps to Test
Expected Behaviour
Other Notes