Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor-voting-verifier): remove old migration handler #693

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

cjcobb23
Copy link
Contributor

No description provided.

@cjcobb23 cjcobb23 requested a review from a team as a code owner November 13, 2024 20:44
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (9f91b1e) to head (c6528b6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/voting-verifier/src/contract.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   93.55%   93.50%   -0.06%     
==========================================
  Files         237      236       -1     
  Lines       35343    35181     -162     
==========================================
- Hits        33066    32896     -170     
- Misses       2277     2285       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cgorenflo
cgorenflo previously approved these changes Nov 13, 2024
@cgorenflo
Copy link
Contributor

I think the current version should still be checked, so it's not possible to accidentally (or maliciously) roll back to this from whichever version we have

@cjcobb23 cjcobb23 merged commit f168b20 into main Nov 14, 2024
7 of 8 checks passed
@cjcobb23 cjcobb23 deleted the rm_voting_verifier_migration branch November 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants