Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to generate unsigned txs in sui scripts #442

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat: add support to generate unsigned txs in sui scripts #442

merged 3 commits into from
Dec 3, 2024

Conversation

blockchainguyy
Copy link
Contributor

@blockchainguyy blockchainguyy requested a review from a team as a code owner November 21, 2024 12:27
npty
npty reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@npty npty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you determine which scripts have to support offline signings? I notice that there're some scripts that haven't been modified e.g. faucet, gas-service, multisig, etc.

sui/its.js Outdated Show resolved Hide resolved
sui/utils/utils.js Show resolved Hide resolved
@blockchainguyy
Copy link
Contributor Author

How do you determine which scripts have to support offline signings? I notice that there're some scripts that haven't been modified e.g. faucet, gas-service, multisig, etc.

Scripts that perform a operation that requires a special role, like add operator or remove operator are the only ones that require offline tag, to be able to generate a tx json file, which will be required later for signing via multisig.

@blockchainguyy blockchainguyy reopened this Dec 3, 2024
@blockchainguyy blockchainguyy merged commit 5380987 into main Dec 3, 2024
6 checks passed
@blockchainguyy blockchainguyy deleted the feat/unsigned-tx-generation branch December 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npty npty npty left review comments

@milapsheth milapsheth milapsheth approved these changes

@apolikamixitos apolikamixitos Awaiting requested review from apolikamixitos apolikamixitos is a code owner automatically assigned from axelarnetwork/chainops

@jcs47 jcs47 Awaiting requested review from jcs47 jcs47 is a code owner automatically assigned from axelarnetwork/chainops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blockchainguyy @milapsheth @npty