Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support caption annotation #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarge
Copy link

@sarge sarge commented Sep 7, 2017

Hello @barbibulle

For your consideration, a small change to signal the caption support for HLS streams. Cleans up the default Safari player offering to play captions on streams that could but do not contain captions.

Cheers

Mark

@barbibulle
Copy link
Contributor

Since the tool currently doesn't generate "#EXT-X-MEDIA:TYPE=CLOSED-CAPTIONS" entries, what value would you pass with the "+captions" media source annotations? Would you pass "NONE" there?

@sarge
Copy link
Author

sarge commented Sep 10, 2017

Correct that is exactly how I would plan on using it. Open to suggestions, and what if anything should be the approach in mp4-dash.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants