Don't try to match anchor track fragmenting after it is finished. #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a secondary track (audio) is slightly longer than the anchor track (video), the mp4fragment tries to match the fragment durations, creating an unexpected short segment at the end, like so:
So each fragment is approximately 2 seconds, except the final video fragment is about 1.07 seconds. The audio is then fragmented into a 1.07 second fragment and a 0.035 second fragment, so that its durations match the video.
Instead, the final audio fragment should be allowed to be up to 2 seconds long, ensuring consistent fragmenting. With this patch applied, the fragmenting looks like the following: