Nixify #41
Open
Nixify #41
+342
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
reviewed
Mar 28, 2024
flake.nix
Outdated
| outputs = inputs@{ self, nixpkgs, flake-parts, ... }: | ||
| flake-parts.lib.mkFlake { inherit inputs; } { | ||
| systems = nixpkgs.lib.systems.flakeExposed; | ||
| imports = [ inputs.haskell-flake.flakeModule ]; |
There was a problem hiding this comment.
You may want to pull in a pre-commit hooks module, see https://git.sr.ht/~jack/hslua-fennel-demo/tree/master/item/flake.nix for an example.
flake.nix
Outdated
Comment on lines
41
to
54
| devShell = { | ||
| # Enabled by default | ||
| enable = true; | ||
|
|
||
| # Programs you want to make available in the shell. | ||
| # Default programs can be disabled by setting to 'null' | ||
| # tools = hp: { fourmolu = hp.fourmolu; ghcid = null; }; | ||
|
|
||
| hlsCheck.enable = true; | ||
| }; | ||
| }; | ||
|
|
||
| # haskell-flake doesn't set the default package, but you can do it here. | ||
| packages.default = self'.packages.amazonka-s3-streaming; |
There was a problem hiding this comment.
I didn't seem to need all that much of this.
There was a problem hiding this comment.
Not sure I understand what you're suggesting I change here.
endgame
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.