Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add notes to two SPDX tests #1352

Merged
merged 2 commits into from
Aug 22, 2024
Merged

docs: add notes to two SPDX tests #1352

merged 2 commits into from
Aug 22, 2024

Conversation

mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Aug 21, 2024

These two tests produce different results in Homebrew's SPDX parser, but that appears to be a bug in Homebrew's parser rather than this one. Added notes to both tests so that we expect the results to be different from what Homebrew returns.

refs #1345 (comment).

cc @cxreiff

These two tests produce different results in Homebrew's SPDX parser,
but that appears to be a bug in Homebrew's parser rather than this one.
Added notes to both tests so that we expect the results to be different
from what Homebrew returns.

refs #1345 (comment).
@mistydemeo mistydemeo requested a review from Gankra August 21, 2024 00:03
Copy link
Contributor

@cxreiff cxreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me- suggested some additional text around the specific difference in behavior in case you find it useful, but not sure how much text you want to cram in the comment.

cargo-dist/src/backend/installer/homebrew.rs Outdated Show resolved Hide resolved
@mistydemeo mistydemeo merged commit f18413a into main Aug 22, 2024
16 checks passed
@mistydemeo mistydemeo deleted the spdx_notes branch August 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants