Skip to content

Conversation

@pnehrer
Copy link
Contributor

@pnehrer pnehrer commented Mar 17, 2025

In spite of what the documentation claims, cargo wix doesn't use certain properties defined in the package's [package.metadata.wix] section:

This PR explicitly reads these properties from metadata and populates builder with any values it finds.

@pnehrer pnehrer marked this pull request as ready for review March 17, 2025 21:23
@mistydemeo
Copy link
Contributor

Sorry for the late review. Makes sense to me - I'll look into adding this to the tests so we can be sure it works.

@mistydemeo
Copy link
Contributor

In testing now, we are bringing these values in from Cargo.toml. For example, in the axolotlsay test, we're getting the axolotlsay package's description and URL. Is your goal here to override those values with something else?

@pnehrer
Copy link
Contributor Author

pnehrer commented Nov 3, 2025

Yes, we were hoping to be able to override these explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants