Support Attestations in Announce Phase #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samypr100
force-pushed
the
support-attestations-announce
branch
3 times, most recently
from
94193ab to
07f7312
Compare
samypr100
force-pushed
the
support-attestations-announce
branch
from
07f7312 to
0c55f28
Compare
Gankra
approved these changes
Oct 31, 2025
Contributor
|
Looks great! |
Gankra
force-pushed
the
support-attestations-announce
branch
from
0c55f28 to
9f44e6d
Compare
Contributor
|
I've rebased it but FYI the "real" main branch of this repo rn is actually the "stable" one -- it's on my TODO list to swap main and stable (current main was for a now defunct 1.0.0 push). |
Contributor
Author
|
Good to know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #2134 fixed the issues reported by zizmor from astral-sh/uv#11357 were merged, the attestation permissions were no longer at the root level of the release workflow as they previously were traditionally. This introduced a side-effect of needing to have a mechanism to differentiate between attesting in host vs announce phase to know where to add the permissions.
This PR provides support when
github-release = "announce"is set, and you needed to attest in thehostphase. You can now explicitly set the attest phase toannounceviagithub-attestations-phase = "announce"to ensure the permissions are correct.