-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/custom chat template #1233
Open
komninoschatzipapas
wants to merge
6
commits into
axolotl-ai-cloud:main
Choose a base branch
from
komninoschatzipapas:feat/custom_chat_template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
62d48d7
feat: custom chat template
komninoschatzipapas f60044f
fix: custom_chat_template
komninoschatzipapas 7ac8a79
docs: fix chat_templates
komninoschatzipapas 9247380
fix: custom_chat_template priority
komninoschatzipapas 3434e36
docs: more conventional chat template for custom_chat_template
komninoschatzipapas 23c1f5d
docs: wrap custom_chat_template string
komninoschatzipapas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -218,7 +218,9 @@ def load_tokenizer(cfg): | |
LOG.debug(f"PAD: {tokenizer.pad_token_id} / {tokenizer.pad_token}") | ||
LOG.debug(f"UNK: {tokenizer.unk_token_id} / {tokenizer.unk_token}") | ||
|
||
if cfg.chat_template: | ||
if cfg.custom_chat_template: | ||
tokenizer.chat_template = cfg.custom_chat_template | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. similar to the chatml replacement, we could consider some sort of standardized string in the chat template that could be replaced based on the configuration. |
||
elif cfg.chat_template: | ||
chat_template_string = chat_templates(cfg.chat_template) | ||
if cfg.default_system_message and cfg.chat_template == "chatml": | ||
chat_template_string = chat_template_string.replace( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"May overwrite the default system message" since you could design the chat template to accept one.