reapply multipack patches after model load for trust_remote_code compat #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm1
force-pushed
the
fix-multipack-remote-code
branch
from
e15bd9a
to
deb77d4
Compare
|
i think a better solution might be fix transformers so it doesn't wipe away monkeypatches between model loads otherwise we'll be chasing down and trying to restore a bunch of patches all over. for example, i ran into this again when trying to patch deepseekv2 for liger support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1873 #1872 #1340 (comment)
note that this was a regression in huggingface/transformers#30370 after which transformers will reload modules causing our patched function to get replaced