Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing OSX installation #2231

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixing OSX installation #2231

wants to merge 6 commits into from

Conversation

SalmanMohammadi
Copy link

@SalmanMohammadi SalmanMohammadi commented Jan 2, 2025

Description

  • This PR automatically omits osx-incompatible dependencies in the setup.py, so we can pip install -e on mac.
  • I've had to update the pylint version in the pre-commit as it was incompatible with 3.12.
  • This comes with minimal testing, so please bear with me as I test more features and roll out more consistent mac support.

Motivation and Context

Closes #2221

How has this been tested?

  • Fresh python 3.12 env
  • pip install -r requirements-dev.txt -r requirements-tests.txt
  • pip install -e .

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

@NanoCode012
Copy link
Collaborator

Thanks for looking into this. Let me know when you need a review.

@SalmanMohammadi SalmanMohammadi marked this pull request as ready for review January 3, 2025 11:34
@SalmanMohammadi SalmanMohammadi changed the title [WIP] Fixing OSX installation Fixing OSX installation Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: metadata-generation-failed in osx/mac
2 participants