Skip to content

Conversation

@ivy-lmu
Copy link
Member

@ivy-lmu ivy-lmu commented Feb 26, 2025

& cleaup

@ivy-lmu ivy-lmu changed the title Temp dir run playwright tests with temporary workspaces Feb 27, 2025
@ivy-lmu ivy-lmu requested review from ivy-cst and ivy-lli February 27, 2025 10:48
@ivy-lmu ivy-lmu merged commit 89c4b81 into master Feb 27, 2025
9 checks passed
@ivy-lmu ivy-lmu deleted the tempDir branch February 27, 2025 10:49
Copy link
Member

@ivy-cst ivy-cst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the docker way and do installations again on the build host istelf. I think this is not the way we want to go.
Why did you change that in this way?
What do you think @alexsuter?

@ivy-lmu
Copy link
Member Author

ivy-lmu commented Feb 28, 2025

You removed the docker way and do installations again on the build host istelf. I think this is not the way we want to go. Why did you change that in this way? What do you think @alexsuter?

The goal of this PR is that each test has its own isolated ivy project. To achieve this, I need to have the built extension, playwright, openvscode server, node, java and maven in one place. Now that this temporary test workspace is working, possible next steps are to get this running again with Docker and also run the openvsocde intergration on github.

@alexsuter
Copy link
Member

image

This is all what I can say

@ivy-cst
Copy link
Member

ivy-cst commented Feb 28, 2025

The goal of this PR is that each test has its own isolated ivy project. To achieve this, I need to have the built extension, playwright, openvscode server, node, java and maven in one place. Now that this temporary test workspace is working, possible next steps are to get this running again with Docker and also run the openvsocde intergration on github.

Ok, why on github?

@ivy-lmu
Copy link
Member Author

ivy-lmu commented Feb 28, 2025

The goal of this PR is that each test has its own isolated ivy project. To achieve this, I need to have the built extension, playwright, openvscode server, node, java and maven in one place. Now that this temporary test workspace is working, possible next steps are to get this running again with Docker and also run the openvsocde intergration on github.

Ok, why on github?

because I want to compare with our internal build node 😽

@alexsuter
Copy link
Member

💋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants