Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for tx committed before read its data #1

Merged

Conversation

chaoticlonghair
Copy link
Contributor

Description

Some tests have read data from contracts, before the transaction which changes the data is committed.

These bugs are only happened after axonweb3/axon#1526 and only in CI because:

Tests

Before this PR:

After this PR:

  • The above tests are fixed.
    p.s. That CI check still has failed tests, they will be fixed in other PRs later; I haven't figured out them now.

@chaoticlonghair
Copy link
Contributor Author

Call for reviewers. @Flouse @sunchengzhu
p.s. I don't know why no reviewers could be added in this repository.

@chaoticlonghair chaoticlonghair marked this pull request as draft November 8, 2023 09:20
@chaoticlonghair chaoticlonghair marked this pull request as ready for review November 8, 2023 09:21
@Flouse
Copy link

Flouse commented Nov 8, 2023

p.s. I don't know why no reviewers could be added in this repository.

The axon-dev team was just added into this repo. Thanks for reminding.

@Flouse Flouse requested review from Flouse and sunchengzhu November 8, 2023 09:23
@Flouse Flouse merged commit ac66a29 into axonweb3:master Nov 8, 2023
@chaoticlonghair chaoticlonghair deleted the bugfix/fix-ci-for-axon-pr-1526 branch November 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants