fix: wait for txs committed before read nonce to build next tx #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoticlonghair
force-pushed
the
bugfix/duplicated-nonces
branch
2 times, most recently
from
ba33160 to
a6a3511
Compare
chaoticlonghair
force-pushed
the
bugfix/duplicated-nonces
branch
from
a6a3511 to
07c2a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't sure whether it's a bug of Axon JSON-RPC or not.
If two transactions with a same sender are sent one by one, then they have a chance to use a same nonce.
So, this PR updates tests to make sure each transaction is constructed after the previous transaction mined.
The tests after this PR should be passed with axonweb3/axon#1526.