Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Axon version to 0.3.0-alpha #1615

Merged
merged 5 commits into from
Dec 4, 2023
Merged

chore: bump Axon version to 0.3.0-alpha #1615

merged 5 commits into from
Dec 4, 2023

Conversation

Flouse
Copy link
Contributor

@Flouse Flouse commented Dec 3, 2023

Changes

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@Flouse Flouse requested a review from KaoImin December 3, 2023 03:46
@Flouse Flouse self-assigned this Dec 3, 2023
@Flouse
Copy link
Contributor Author

Flouse commented Dec 3, 2023

/run-ci

Copy link

github-actions bot commented Dec 3, 2023

CI tests run on commit:

CI test list:

  • openzeppelin_test_1_5_and_12_15.yml
  • openzeppelin_test_16_19.yml
  • openzeppelin_test_6_10.yml
  • openzeppelin_test_11.yml
  • v3_core_test.yml
  • web3_compatible.yml

Please check ci test results later.

@Flouse Flouse changed the title [Waiting PR#1591] Bump Axon version to 0.3.0-dev [Waiting for PR#1591] Bump Axon version to 0.3.0-dev Dec 3, 2023
@Flouse Flouse changed the title [Waiting for PR#1591] Bump Axon version to 0.3.0-dev Bump Axon version to 0.3.0-dev Dec 4, 2023
@Flouse Flouse requested a review from Simon-Tl December 4, 2023 06:40
@Flouse Flouse marked this pull request as ready for review December 4, 2023 06:40
@Flouse Flouse requested a review from a team as a code owner December 4, 2023 06:40
@KaoImin KaoImin changed the title Bump Axon version to 0.3.0-dev chore: bump Axon version to 0.3.0-dev Dec 4, 2023
@github-actions github-actions bot added the chore label Dec 4, 2023
@KaoImin
Copy link
Contributor

KaoImin commented Dec 4, 2023

dev is not a preceding identifier, why use this?

@Flouse
Copy link
Contributor Author

Flouse commented Dec 4, 2023

dev is not a preceding identifier, why use this?

My plan is to test 0.3.0-dev interanl, and then bump to v0.3.0-beta later if everything goes well.

Do think 0.3.0-alpha is better than 0.3.0-dev?

@KaoImin
Copy link
Contributor

KaoImin commented Dec 4, 2023

dev is not a preceding identifier, why use this?

My plan is to test 0.3.0-dev interanl, and then bump to v0.3.0-beta later if everything goes well.

Do think 0.3.0-alpha is better than 0.3.0-dev?

If only want to do some internal tests, no need to release a version. A commit ID is enough or checkout a branch.

Simon-Tl
Simon-Tl previously approved these changes Dec 4, 2023
@Flouse
Copy link
Contributor Author

Flouse commented Dec 4, 2023

If only want to do some internal tests, no need to release a version. A commit ID is enough or checkout a branch.

  1. updated: chore: bump Axon version to 0.3.0-alpha
  2. just want a more readable version name for web3_clientVersion RPC and axon --version
  3. I won't create a new release/tag for 0.3.0-alpha
  4. created a new branch 0.3.0-alpha to trigger the docker image building workflow

@Flouse Flouse changed the title chore: bump Axon version to 0.3.0-dev chore: bump Axon version to 0.3.0-alpha Dec 4, 2023
@Flouse Flouse merged commit d9e7a17 into main Dec 4, 2023
24 checks passed
@Flouse Flouse linked an issue Dec 5, 2023 that may be closed by this pull request
6 tasks
@KaoImin KaoImin deleted the 0.3.x-dev branch December 5, 2023 10:25
@Flouse Flouse restored the 0.3.x-dev branch December 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Axon v0.3.0-beta
3 participants