Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Proof.block_hash serde rename as proposal_hash #1618

Merged
merged 2 commits into from
Dec 5, 2023
Merged

refactor: Proof.block_hash serde rename as proposal_hash #1618

merged 2 commits into from
Dec 5, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 4, 2023 •
edited by Flouse
Loading

What this PR does / why we need it?

To avoid ambiguity, Proof.block_hash rename as proposal_hash when serde::serialize. It should fill the proposal hash.

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from a team as a code owner December 4, 2023 04:05
@KaoImin KaoImin requested review from Flouse, ashuralyk and chaoticlonghair and removed request for sunchengzhu December 4, 2023 04:08
blckngm
blckngm reviewed Dec 4, 2023
View reviewed changes
protocol/src/types/block.rs Outdated Show resolved Hide resolved
@KaoImin KaoImin requested a review from blckngm December 4, 2023 06:44
follow review opinion
295c6f8 
fix unit test
@Flouse
Copy link
Contributor

Flouse commented Dec 4, 2023

/run-ci

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

CI tests run on commit:

CI test list:

  • openzeppelin_test_6_10.yml
  • openzeppelin_test_1_5_and_12_15.yml
  • openzeppelin_test_11.yml
  • openzeppelin_test_16_19.yml
  • v3_core_test.yml
  • web3_compatible.yml

Please check ci test results later.

@Flouse Flouse added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 4124476 Dec 5, 2023
@KaoImin KaoImin deleted the rename-block-hash branch December 5, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@chaoticlonghair chaoticlonghair chaoticlonghair approved these changes

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust wenyuanhust is a code owner automatically assigned from axonweb3/axon-dev

@Flouse Flouse Awaiting requested review from Flouse

@ashuralyk ashuralyk Awaiting requested review from ashuralyk

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different JSON-RPC methods return different block_hash for a same height.
4 participants
@KaoImin @Flouse @blckngm @chaoticlonghair