Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Remove isProp #1011

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Misc: Remove isProp #1011

merged 8 commits into from
Nov 11, 2023

Conversation

HoshinoTented
Copy link
Contributor

This PR:

  • Remove the uses of isProp in TermComparator

@HoshinoTented HoshinoTented added the prop Universe of propositions label Nov 11, 2023
@HoshinoTented HoshinoTented added this to the v0.30 milestone Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1011 (40e1859) into main (8682036) will decrease coverage by 0.03%.
Report is 8 commits behind head on main.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #1011      +/-   ##
============================================
- Coverage     81.82%   81.79%   -0.03%     
+ Complexity     3500     3471      -29     
============================================
  Files           288      287       -1     
  Lines         10694    10640      -54     
  Branches       1296     1281      -15     
============================================
- Hits           8750     8703      -47     
+ Misses         1217     1216       -1     
+ Partials        727      721       -6     
Files Coverage Δ
base/src/main/java/org/aya/concrete/Expr.java 85.38% <100.00%> (-0.26%) ⬇️
.../main/java/org/aya/concrete/desugar/Desugarer.java 78.46% <ø> (-0.33%) ⬇️
base/src/main/java/org/aya/core/def/CtorDef.java 60.00% <ø> (-6.67%) ⬇️
base/src/main/java/org/aya/core/term/SortTerm.java 80.00% <ø> (-8.89%) ⬇️
base/src/main/java/org/aya/generic/SortKind.java 100.00% <100.00%> (ø)
base/src/main/java/org/aya/tyck/ExprTycker.java 83.85% <100.00%> (-0.10%) ⬇️
base/src/main/java/org/aya/tyck/StmtTycker.java 90.59% <100.00%> (-1.00%) ⬇️
...e/src/main/java/org/aya/tyck/pat/ClauseTycker.java 95.71% <100.00%> (-0.12%) ⬇️
...src/main/java/org/aya/tyck/pat/PatternProblem.java 93.65% <ø> (-0.38%) ⬇️
.../src/main/java/org/aya/tyck/pat/PatternTycker.java 89.44% <100.00%> (+0.91%) ⬆️
... and 7 more

... and 2 files with indirect coverage changes

@ice1000
Copy link
Member

ice1000 commented Nov 11, 2023

Let me do more

@ice1000 ice1000 merged commit 8f7acdf into main Nov 11, 2023
5 of 6 checks passed
@ice1000 ice1000 deleted the remove-prop branch November 11, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prop Universe of propositions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants