Grouping methods in ExprTycker #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoshinoTented
commented
Dec 8, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
============================================
+ Coverage 81.78% 81.85% +0.07%
+ Complexity 3471 3441 -30
============================================
Files 287 287
Lines 10640 10638 -2
Branches 1281 1284 +3
============================================
+ Hits 8702 8708 +6
+ Misses 1216 1207 -9
- Partials 722 723 +1 ☔ View full report in Codecov by Sentry. |
|
Thank you! 🙏 |
imkiva
reviewed
Dec 10, 2023
Comment on lines
+172
to
+176
| return lhsResult.preclause.expr().map(e -> {// In case the patterns are malformed, do not check the body | ||
| // as we bind local variables in the pattern checker, | ||
| // and in case the patterns are malformed, some bindings may | ||
| // not be added to the localCtx of tycker, causing assertion errors | ||
| return lhsResult.hasError ? new ErrorTerm(e, false) : exprTycker.inherit(e, lhsResult.type).wellTyped(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR groups methods in ExprTycker.