Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 21 features #1023

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Use Java 21 features #1023

merged 3 commits into from
Dec 13, 2023

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Dec 13, 2023

Yeeassss

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (1e74abb) 81.33% compared to head (4dd8428) 81.36%.
Report is 1 commits behind head on main.

Files Patch % Lines
base/src/main/java/org/aya/prettier/Codifier.java 25.00% 3 Missing ⚠️
...c/main/java/org/aya/tyck/unify/TermComparator.java 85.71% 0 Missing and 3 partials ⚠️
...c/main/java/org/aya/core/visitor/BetaExpander.java 33.33% 1 Missing and 1 partial ⚠️
base/src/main/java/org/aya/tyck/ExprTycker.java 66.66% 2 Missing ⚠️
base/src/main/java/org/aya/core/pat/PatUnify.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1023      +/-   ##
============================================
+ Coverage     81.33%   81.36%   +0.03%     
- Complexity     3526     3529       +3     
============================================
  Files           291      291              
  Lines         10761    10758       -3     
  Branches       1307     1308       +1     
============================================
+ Hits           8752     8753       +1     
+ Misses         1264     1263       -1     
+ Partials        745      742       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 added this to the v0.30 milestone Dec 13, 2023
@ice1000 ice1000 added java Related to Java or JDK refactoring labels Dec 13, 2023
@ice1000 ice1000 merged commit c54bc3d into main Dec 13, 2023
5 of 6 checks passed
@ice1000 ice1000 deleted the 21 branch December 13, 2023 07:49
@@ -2,7 +2,7 @@
# The Version of this project, aka, The Aya Theorem Prover.
# Remove "-SNAPSHOT" suffix and run gradle publish to release a new version.
# After that, increase the version number and add "-SNAPSHOT" suffix back for next cycle.
project = "0.30"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -SNAPSHOT to the version because it is in the main branch, and such a "release" version will prevent the CI from uploading nightly builds to https://s01.oss.sonatype.org/content/repositories/snapshots

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😨 oh no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Related to Java or JDK refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants