Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependent types in variable #1226

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Support dependent types in variable #1226

wants to merge 9 commits into from

Conversation

mio-19
Copy link
Contributor

@mio-19 mio-19 commented Dec 17, 2024

fix #1220

passed:

variable A : Type
variable a : A

@ice1000
Copy link
Member

ice1000 commented Dec 17, 2024

Can you write a test?

@mio-19 mio-19 force-pushed the variable branch 6 times, most recently from 9bda23f to 621d098 Compare December 27, 2024 09:09
@mio-19 mio-19 force-pushed the variable branch 3 times, most recently from 11a334e to 549c546 Compare January 6, 2025 04:32
@mio-19 mio-19 marked this pull request as ready for review January 6, 2025 05:00
@mio-19 mio-19 changed the title resolve: add introduceDependencies for variables Support dependent types in variable Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 60.49383% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (511c97f) to head (966b3c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/org/aya/resolve/visitor/StmtResolver.java 53.84% 9 Missing and 3 partials ⚠️
...a/resolve/visitor/VariableDependencyCollector.java 68.96% 5 Missing and 4 partials ⚠️
...a/org/aya/resolve/error/CyclicDependencyError.java 0.00% 6 Missing ⚠️
...ain/java/org/aya/resolve/visitor/ExprResolver.java 75.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1226      +/-   ##
============================================
- Coverage     83.38%   83.23%   -0.16%     
- Complexity     4219     4228       +9     
============================================
  Files           384      386       +2     
  Lines         12213    12288      +75     
  Branches       1406     1422      +16     
============================================
+ Hits          10184    10228      +44     
- Misses         1283     1304      +21     
- Partials        746      756      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000
Copy link
Member

ice1000 commented Jan 7, 2025

Why are there 39 commits in the PR, and 1000+ loc changes?

image

@mio-19
Copy link
Contributor Author

mio-19 commented Jan 7, 2025

Why are there 39 commits in the PR, and 1000+ loc changes?

image

I entered a wrong git rebase command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dependent types in variable
2 participants