Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize DiskLibraryOwner #1262

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Properly initialize DiskLibraryOwner #1262

merged 2 commits into from
Dec 25, 2024

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Dec 25, 2024

It should have srcPath in modulePath

@ice1000 ice1000 marked this pull request as ready for review December 25, 2024 22:50
@ice1000 ice1000 added this to the v0.37 milestone Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (3bd885e) to head (4025921).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1262   +/-   ##
=========================================
  Coverage     82.79%   82.79%           
  Complexity     3971     3971           
=========================================
  Files           365      365           
  Lines         11707    11707           
  Branches       1365     1365           
=========================================
  Hits           9693     9693           
  Misses         1292     1292           
  Partials        722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 merged commit 4f6b39f into main Dec 25, 2024
6 checks passed
@ice1000 ice1000 deleted the ice1000 branch December 25, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant