Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify confluence check #1285

Merged
merged 6 commits into from
Jan 25, 2025
Merged

Simplify confluence check #1285

merged 6 commits into from
Jan 25, 2025

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jan 25, 2025

This PR simplifies confluence check by using a prefix count array data structure for the clause index in MCTs.

It also stores MCTs in the core, which will be helpful later.

@ice1000 ice1000 added confluence tyck: pattern Pattern type checking labels Jan 25, 2025
@ice1000
Copy link
Member Author

ice1000 commented Jan 25, 2025

@ice1000 ice1000 added this to the v0.38 milestone Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (bbf7086) to head (cb5abcb).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
base/src/main/java/org/aya/tyck/StmtTycker.java 94.44% 0 Missing and 1 partial ⚠️
...x/src/main/java/org/aya/prettier/CorePrettier.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1285      +/-   ##
============================================
+ Coverage     83.38%   83.41%   +0.02%     
+ Complexity     4239     4235       -4     
============================================
  Files           385      386       +1     
  Lines         12289    12311      +22     
  Branches       1418     1423       +5     
============================================
+ Hits          10247    10269      +22     
  Misses         1291     1291              
  Partials        751      751              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000
Copy link
Member Author

ice1000 commented Jan 25, 2025

Beautiful

@ice1000 ice1000 merged commit 0830357 into main Jan 25, 2025
6 checks passed
@ice1000 ice1000 deleted the ice1000 branch January 25, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confluence tyck: pattern Pattern type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant