-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Flow Dissector Programs #802
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far!
Apart from one comment I posted, it would be nice to add an integration test.
0ab5fe6
to
c457da0
Compare
Added a integration test that's mostly a clone of the basic_uprobe integration test. Is this the right test or do we want something more comprehensive? |
bf3efa7
to
1c58716
Compare
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
@azenna, this pull request is now in conflict and requires a rebase. |
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
@azenna, this pull request is now in conflict and requires a rebase. |
@azenna, this pull request is now in conflict and requires a rebase. |
1c58716
to
1d85f5e
Compare
1d85f5e
to
de8963b
Compare
Rebased, marking ready for review. Hope @dave-tucker can take a look. |
239e6e6
to
b7489cc
Compare
b7489cc
to
8d1e906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
Adds support for flow dissector programs. Only (1/5) know what I am doing and would appreciate feedback!
#216
This change is