fixes issue #19 - add Wikimedia Image of the Day support #39
Conversation
|
Hello @hecris! Thanks for updating the PR.
Comment last updated on October 02, 2018 at 16:47 Hours UTC |
|
Thanks for the PR. As you can see the tests have failed mainly because of PEP8 issues. If you wish you can make another commit making PEP8 changes, if not, simply tell me and I will do them. Also please change the README file accordingly. |
dwc/wikimedia_wallpaper_changer.py
Outdated
|
|
||
| def picpath_wikimedia(saveDir, SHOW_DEBUG): | ||
| photo_url = getphotourl() | ||
| wikimedia_path = saveDir + 'Wikimedia:' + str(date) + str(random.randint(1, 100000)) + '.jpg' |
There was a problem hiding this comment.
No need of random as Wikimedia uploads only one picture every day.
|
Really great job! @hecris Let me analyse the code and I will merge it if it works it correctly. 😄 |
|
The original image has to be resized to fit the desktop. This is probably what causes the lack of quality. What do you suggest? |
|
Really appreciate your effort, but it seems you are scrapping the image from Wikimedia homepage but as you can see it is not of higher quality. For example today's picture from Wikimedia homepage: https://upload.wikimedia.org/wikipedia/commons/thumb/6/64/Juvenile_Nubian_ibex_in_Mitzpe_Ramon_%2840409%29.jpg/500px-Juvenile_Nubian_ibex_in_Mitzpe_Ramon_%2840409%29.jpg, and this is real picture: https://upload.wikimedia.org/wikipedia/commons/6/64/Juvenile_Nubian_ibex_in_Mitzpe_Ramon_(40409).jpg |
|
Got it, I'll change it |
|
Don't forget to write your name in the Contributors section! As always, let me know if any help is required. |
|
@ayan-b I just committed a change that should get the highest quality image available. Let me know if this works! PS could you add me to the contributors section? (if the changes are successful) |
|
Make a commit adding yourself to the contributors section. 😉 |
.jpg){kind=link}
closes #19