Conversation
Contributor
|
@ayourtch They look good to me. Thanks. |
Owner
Author
|
Ok then I will merge it, and we kick its tires for real! Thanks for looking at it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@angus19 - I've spent some time this past couple of weeks building a somewhat better test harness,
such that we could have more than "if it compiles ship it" CI. Could you have a look / try it out and tell me what you think ?
The "boring" way would have been to just build a disk image with python and scaly and do all the tests from there, but why make things simpler when you can make them more fun ? :) With the current approach there is a pretty tight control over the entire thing, and should hopefully be relatively light.
On the first run, the "trivial" test has caught the UBSAN complaining about the indexing into a zero-sized array, so there is a second patch that takes care of that. @detobate @dedeckeh - adding you as well as an FYI, for feedback.