feat: add Hana Wallet support#95
Merged
Merged
Conversation
Contributor
|
@azbang can we have a pairs of eyes on this one soon? thanks! |
Squashed from kryptopoo/near-connect#feature/add-hana-wallet (originally PR #1, 3 commits).
Manifest:
- Point executor at Hana-Technology/near-connect feature branch (was azbang/, 404)
- Switch iOS store URL to /us/ locale (was /vn/)
hana.ts source:
- checkExist throws after triggering install prompt so callers don't fall through to a hana() call that's guaranteed to fail
- signIn validates accountId before returning (was returning [{undefined, undefined}] on incomplete sign-in)
- signAndSendTransaction replaces destructure of getAccounts() result with a length check (the [{accountId}] = [] destructure crashed before the if-check could run)
- signOut swallows errors since the extension exposes no near_disconnect method; comment explains intent
- All error paths preserve cause via { cause: error } and console.error with method name
- signMessage returns normalized { accountId, publicKey, signature } instead of raw extension response
- signAndSendTransactions reports failure index so partial-success state is debuggable
- Drop unused connectorActionsToNearActions import (extension consumes ConnectorAction shape directly per NearService.createAction)
- Top-of-file TODO for vendor-hosted icon replacement
repository/hana.js: rebuilt via yarn build:hana
Replaces the Chrome Web Store CDN icon URL (fragile to extension republish / CDN ID rotation) with a stable Cloudinary-hosted SVG provided by the Hana team. Removes the now-resolved TODO in hana.ts.
Add Hana Wallet to the manifest list in README.md and the supported wallets line in llms.txt. Also drop a stale internal PR reference from the Hana connector source.
tzechuen
force-pushed
the
feature/hana-wallet
branch
from
June 15, 2026 02:44
bcae453 to
50de13a
Compare
Contributor
Author
|
@azbang I've just fixed the merge conflicts, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Hana Wallet as a NEAR Connect sandbox wallet, following the extension-wallet pattern used by OKX. Hana is available as a Chrome extension and as iOS/Android apps.
Files:
near-wallets/src/hana.ts— connector source (window.selector.external("hanaWallet.near", ...)pattern, mirrors OKX)repository/hana.js— built executor (reproducible viaPACKAGE=hana yarn build)repository/manifest.json— new wallet entrynear-wallets/package.json—build:hanascript wired intobuild:walletsREADME.md/llms.txt— added to the supported-wallets listsFeature support
Declared in manifest, implemented in source:
signMessagesignInWithoutAddKeysignAndSendTransactionsignAndSendTransactions(sequential — Hana extension has no batch endpoint)Not supported by the Hana extension today:
signInAndSignMessage,signInWithFunctionCallKey,signDelegateActions,verifyOwner,createSignedTransaction,signTransaction,signNep413Message. Stubbed to throw "Method not supported" and omitted from manifest features.