Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support manila in workstation #131

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Support manila in workstation #131

merged 11 commits into from
Feb 2, 2024

Conversation

sjpb
Copy link
Contributor

@sjpb sjpb commented Jan 23, 2024 •
edited
Loading

  • Adds ceph client install to workstation ansible builds
  • Adds azimuth user to desktop, used as guacamole user

@sjpb sjpb requested review from mkjpryor and a team as code owners January 23, 2024 13:59
@sjpb sjpb mentioned this pull request Jan 23, 2024
Merged
@sjpb sjpb force-pushed the feat/manila branch 4 times, most recently from 479017f to af26e64 Compare January 23, 2024 16:02
@mkjpryor mkjpryor added the enhancement New feature or request label Jan 24, 2024
JohnGarbutt
JohnGarbutt requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, cool, we should get that tag sorted, but otherwise cool 👍

JohnGarbutt
JohnGarbutt approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

JohnGarbutt
JohnGarbutt approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice 👍

mkjpryor
mkjpryor approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkjpryor mkjpryor merged commit 4dcbf85 into main Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnGarbutt JohnGarbutt JohnGarbutt approved these changes

@mkjpryor mkjpryor mkjpryor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjpb @JohnGarbutt @mkjpryor