-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Cancel Safety using CmdExecution
and blocks
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_fmt`. Reduces the confusion that `None` is `Option::None`, but really could be `Item::State::None`.
azriel91
force-pushed
the
feature/141/cancel-safety
branch
from
August 25, 2023 05:31
161fda9
to
c0680c4
Compare
azriel91
force-pushed
the
feature/141/cancel-safety
branch
2 times, most recently
from
August 25, 2023 11:32
8280e00
to
4fd980e
Compare
azriel91
force-pushed
the
feature/141/cancel-safety
branch
from
August 26, 2023 04:19
4fd980e
to
366280b
Compare
…)>` impl from `CmdBlockWrapper`.
azriel91
force-pushed
the
feature/141/cancel-safety
branch
from
December 1, 2023 06:48
8a1e22b
to
fcc0cb5
Compare
…have been processed.
… on `CmdOutcome::ItemError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141.
Plenty to do:
CmdExecution
for all*Cmd
sinterruptible
betweenCmdBlock
executions.All very large tasks.
Don't forget:
panic!
s in fetches withError
(probably).CmdBlock::Input
andOutcome
types in the error message.CmdExecution
's chain ofCmdBlock
s in the error message.state_clean
from theStatesClean
map, instead of allocating another.interruptible
in eachCmdBlock
's item iterator.