Fixed coding style issues and adding input checks to functions #41
Conversation
LBreugelmans
commented
Dec 4, 2024
•
LBreugelmans
commented
- make output of generate_pd_map_and_indicator() silent in readme to avoid showing personal folder path
- fix improve coding style #33
- add input checks to start of functions
- update version
- run codemeta
- assign reviewer
To avoid showing personal folder path.
- accidental substitution of MRCA in ape::getMRCA function - names of list elements not correctly assigned in retrieve_example_data()
There was a problem hiding this comment.
Hi
Thanks for the fast work.
There are some small comments, often because you have more than 80 characters on one line.
It is not really good practice to have all these if statements, this increases the cyclomatic complexity. There is a stopifnot() function and the assertthat package also has some good functions. In the guidelines they have other recommendations.
I will give some examples. Your choice if you want to implement this.
I have updated the package version in the zenodo file
R/aggregate_cube.R
Outdated
| } | ||
|
|
||
| # Check that the 'eeacellcode' column exists and does not contain NA | ||
| if (any(is.na(mcube$eeacellcode))) { |
There was a problem hiding this comment.
perhaps use assertthat::noNA()? instead of if statement
| proceeding.") | ||
| } | ||
|
|
||
| if (!"CELLCODE" %in% colnames(grid)) { |
There was a problem hiding this comment.
stopifnot (and assertthat):
stopifnot("grid must contain a column named 'CELLCODE' for grid cell codes." = assertthat::has_name(grid, "CELLCODE"))
|
Please run |
Co-authored-by: Ward Langeraert <[email protected]> Signed-off-by: LBreugelmans <[email protected]>
Join R-universe
