Feature/32 add mobile phone node v3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the VerificationStatus class and its related methods. The class is responsible for managing different verification statuses. Associated unit tests have also been added to validate its functionality. Additionally, a minor change has been made in the ApiClient to ensure the 'context' is always a string. Signed-off-by: B24io <[email protected]>
This commit integrates mobile phone handling in the card and contact addition process. Both additions of contacts with and without mobile phones are now supported, which are also covered in the new test cases. The mobile phone is also now accounted for in the card verification process. Additionally, HTTP client timeout has been reduced from 60 to 30. Signed-off-by: B24io <[email protected]>
Method signatures for `Loyalty\SDK\Services\Admin\Contacts::add` are updated to make `$mobilePhone` nullable. The return types of `getById` methods have been changed. Also, data handling in the `MobilePhoneItemResult` class has been improved to better handle instances where the `PhoneNumberUtil` instance is not created. Tests are updated to reflect these changes. Signed-off-by: B24io <[email protected]>
This commit refactors the test cases within ContactsTest.php file, ensuring better code readability and data integrity checks. Furthermore, adjustments have been also made to property annotations across multiple classes, altering both type definitions and treating PhpDoc types as uncertain. Lastly, the docker-compose file version has been updated to 3.8. Signed-off-by: B24io <[email protected]>
The incorrect annotation "@var non-empty-string" was removed from FullName.php. This cleanup enhances code readability and adheres to the proper syntax for variable annotation. Signed-off-by: B24io <[email protected]>
The signature for the method `getById` in the `Cards` service has been changed from `CardItemResult` to `CardResult`. The required changes have been made in the `Cards` class and the associated test. A new class `CardResult` has also been added. Signed-off-by: B24io <[email protected]>
Signed-off-by: B24io <[email protected]>
b24io-sdk
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
b24io-sdk
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.