添加websocket和smtp通知方法，添加bark通知，websocket为qq机器人预留。 #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add email and websocket notification
There was a problem hiding this comment.
PR Overview
This PR introduces new notification methods via WebSocket and Email in the BetterGenshinImpact project, expanding the notification system's capabilities.
- Added EmailNotifier and WebSocketNotifier implementations
- Updated NotificationService to initialize and register these new notifiers based on configuration
- Enhanced NotificationConfig to include settings for the new notifiers
Reviewed Changes
| File | Description |
|---|---|
| BetterGenshinImpact/Service/Notifier/EmailNotifier.cs | Adds asynchronous email sending via SMTP with basic error handling |
| BetterGenshinImpact/Service/Notifier/WebSocketNotifier.cs | Introduces WebSocket-based notification sending with connection management |
| BetterGenshinImpact/Service/Notification/NotificationService.cs | Includes initialization logic for WebSocketNotifier and EmailNotifier in the service startup |
| BetterGenshinImpact/Service/Notification/NotificationConfig.cs | Extends configuration to support WebSocket and Email notifications |
| BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs | Adds test command methods for WebSocket and Email notifications |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
|
|
||
| await smtpClient.SendMailAsync(mailMessage); | ||
| } | ||
| catch (System.Exception ex) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
huiyadanli
requested changes
Mar 9, 2025
|
话说邮件通知值得把图片加上吗 |
|
如果用qq邮箱的话应该是很方便的，能直接点进去看见 |
- 提升 EmailNotifier 中的 SmtpClient 为类的成员变量，并在构造函数中初始化，优化资源使用 - 改进 WebSocketNotifier 的连接和重连逻辑，提高稳定性 - 优化通知器的错误处理和日志记录，增强可维护性
huiyadanli
approved these changes
Mar 11, 2025
wy3057
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces three new notification methods—WebSocket, Email, and Bark—to enhance the notification system. It also updates configuration and initialization routines in the NotificationService and adds corresponding test commands in the settings page.
- Added EmailNotifier, WebSocketNotifier, and BarkNotifier classes
- Extended NotificationConfig with new properties, and updated NotificationService to register the new notifiers
- Added UI commands in the settings page to test the new notification channels
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| BetterGenshinImpact/Service/Notifier/EmailNotifier.cs | Introduces email notification functionality |
| BetterGenshinImpact/Service/Notifier/WebSocketNotifier.cs | Adds WebSocket notifications with connection handling |
| BetterGenshinImpact/Service/Notifier/BarkNotifier.cs | Implements Bark notifications; potential issue with device keys iteration |
| BetterGenshinImpact/Service/Notification/NotificationService.cs | Updates notifier registration and adds resource disposal |
| BetterGenshinImpact/Service/Notification/NotificationConfig.cs | Adds configuration for WebSocket, Email, and Bark |
| BetterGenshinImpact/ViewModel/Pages/CommonSettingsPageViewModel.cs | Adds test command methods for new notifications |
fix: remove api.day.app
huiyadanli
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and enhancements to the notification system in the
BetterGenshinImpactproject. The most significant changes include the addition of WebSocket and Email notification support, as well as the necessary configurations and initializations for these new notifiers.New Notification Features:
Added WebSocket notification support:
WebSocketNotifierclass to handle WebSocket notifications.NotificationConfigto include properties for WebSocket configuration.NotificationServiceto initialize theWebSocketNotifierbased on configuration.Added Email notification support:
EmailNotifierclass to handle Email notifications.NotificationConfigto include properties for Email configuration.NotificationServiceto initialize theEmailNotifierbased on configuration.Configuration and Initialization:
NotificationConfigclass to include new properties for WebSocket and Email configurations.NotificationServiceto initialize the new notifiers based on the provided configurations.Minor Changes:
NotificationConfig.csandNotificationService.csfor new dependencies. [1] [2]CommonSettingsPage.xamlto accommodate new settings.