Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some definitions #211

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix some definitions #211

merged 1 commit into from
Apr 17, 2024

Conversation

zloirock
Copy link
Member

@zloirock zloirock commented Apr 3, 2024 •
edited
Loading

I mentioned those problems in other issues and PRs like here #198 (comment), but they are still not fixed.

liuxingbaoyu
liuxingbaoyu approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I realize this is a stage 1 proposal, so I can't search for it. :)

@zloirock
Copy link
Member Author

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo merged commit 8107ebc into babel:main Apr 17, 2024
7 checks passed
@zloirock zloirock deleted the fix-some-definitions branch April 17, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zloirock @nicolo-ribaudo @liuxingbaoyu