[corejs3] Fix disappearing polyfills with old preset-env versions #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
pr-12554
branch
from
5d30ead
to
75b45c3
Compare
nicolo-ribaudo
commented
Jan 9, 2021
| @@ -0,0 +1,291 @@ | |||
| import "core-js/modules/es.symbol"; | |||
There was a problem hiding this comment.
These are without extension because they are injected by the old preset-env version, not by this plugin.
nicolo-ribaudo
force-pushed
the
pr-12554
branch
from
75b45c3
to
4f06247
Compare
nicolo-ribaudo
force-pushed
the
pr-12554
branch
2 times, most recently
from
9081d5f
to
ef12edd
Compare
nicolo-ribaudo
force-pushed
the
pr-12554
branch
from
ef12edd
to
d69cac8
Compare
|
Rebasing this on |
existentialism
previously approved these changes
Feb 25, 2021
|
No don't approve this is currently broken 🙏 |
|
Misread derp, sorry |
nicolo-ribaudo
force-pushed
the
main
branch
2 times, most recently
from
b63f4c9
to
3e531b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as babel/babel#12554. The first commit shows that
babel-plugin-polyfill-corejs3has the bug, and the second one fixes it.Fixes babel/babel#12545