This repository was archived by the owner on Sep 8, 2025. It is now read-only.
feat: keep form data in memory #1525
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import { useFormContext, useWatch } from "@babylonlabs-io/core-ui"; | ||
| import { useEffect, useMemo, useRef } from "react"; | ||
|
|
||
| import { | ||
| useFormPersistenceState, | ||
| type BabyStakeDraft, | ||
| } from "@/ui/common/state/FormPersistenceState"; | ||
|
|
||
| export function BabyFormPersistence() { | ||
| const { setValue, control } = useFormContext<BabyStakeDraft>(); | ||
| const { babyStakeDraft, setBabyStakeDraft } = useFormPersistenceState(); | ||
| const hasHydratedRef = useRef(false); | ||
|
|
||
| const amount = useWatch({ control, name: "amount" }); | ||
| const validatorAddresses = useWatch({ control, name: "validatorAddresses" }); | ||
| const feeAmount = useWatch({ control, name: "feeAmount" }); | ||
|
|
||
| // Hydrate once on mount | ||
| useEffect(() => { | ||
| if (hasHydratedRef.current) return; | ||
|
|
||
| if (babyStakeDraft) { | ||
| if (babyStakeDraft.amount !== undefined) { | ||
| setValue("amount", babyStakeDraft.amount, { | ||
| shouldValidate: true, | ||
| shouldDirty: false, | ||
| shouldTouch: false, | ||
| }); | ||
| } | ||
| if (babyStakeDraft.validatorAddresses !== undefined) { | ||
| setValue("validatorAddresses", babyStakeDraft.validatorAddresses, { | ||
| shouldValidate: true, | ||
| shouldDirty: false, | ||
| shouldTouch: false, | ||
| }); | ||
| } | ||
| if (babyStakeDraft.feeAmount !== undefined) { | ||
| setValue("feeAmount", babyStakeDraft.feeAmount, { | ||
| shouldValidate: true, | ||
|
There was a problem hiding this comment. Could probably move these {shouldValidate: true, shouldDirty: false, shouldTouch: false} to a const and assign on each of these setValues. Would make the code a bit cleaner. Actually, since we are at it, this is simply a matter of doing something like |
||
| shouldDirty: false, | ||
| shouldTouch: false, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| hasHydratedRef.current = true; | ||
| }, [babyStakeDraft, setValue]); | ||
|
|
||
| const draft = useMemo( | ||
| () => ({ | ||
| amount, | ||
| validatorAddresses, | ||
| feeAmount, | ||
| }), | ||
| [amount, validatorAddresses, feeAmount], | ||
| ); | ||
|
|
||
| // Persist on change | ||
| useEffect(() => { | ||
| setBabyStakeDraft(draft); | ||
| }, [draft, setBabyStakeDraft]); | ||
|
|
||
| return null; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,94 @@ | ||||||||
| import { useFormContext, useWatch } from "@babylonlabs-io/core-ui"; | ||||||||
| import { useEffect, useMemo, useRef } from "react"; | ||||||||
|
|
||||||||
| import { | ||||||||
| useFormPersistenceState, | ||||||||
| type BtcStakeDraft, | ||||||||
| } from "@/ui/common/state/FormPersistenceState"; | ||||||||
| import { useStakingState } from "@/ui/common/state/StakingState"; | ||||||||
|
|
||||||||
| export function BtcFormPersistence() { | ||||||||
| const { setValue, control } = useFormContext<BtcStakeDraft>(); | ||||||||
| const { btcStakeDraft, setBtcStakeDraft } = useFormPersistenceState(); | ||||||||
| const { stakingInfo } = useStakingState(); | ||||||||
| const hasHydratedRef = useRef(false); | ||||||||
|
|
||||||||
| const finalityProviders = useWatch({ control, name: "finalityProviders" }); | ||||||||
| const amount = useWatch({ control, name: "amount" }); | ||||||||
| const term = useWatch({ control, name: "term" }); | ||||||||
| const feeRate = useWatch({ control, name: "feeRate" }); | ||||||||
| const feeAmount = useWatch({ control, name: "feeAmount" }); | ||||||||
|
|
||||||||
| // Hydrate once on mount | ||||||||
| useEffect(() => { | ||||||||
| if (hasHydratedRef.current) return; | ||||||||
|
|
||||||||
| if (btcStakeDraft) { | ||||||||
| if (btcStakeDraft.finalityProviders) { | ||||||||
| setValue("finalityProviders", btcStakeDraft.finalityProviders, { | ||||||||
| shouldValidate: false, | ||||||||
|
|
||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
| if (btcStakeDraft.amount !== undefined) { | ||||||||
| setValue("amount", btcStakeDraft.amount, { | ||||||||
| shouldValidate: true, | ||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
| if (btcStakeDraft.term !== undefined) { | ||||||||
| setValue("term", btcStakeDraft.term, { | ||||||||
| shouldValidate: false, | ||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
| if (btcStakeDraft.feeRate !== undefined) { | ||||||||
| setValue("feeRate", btcStakeDraft.feeRate, { | ||||||||
| shouldValidate: true, | ||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
| if (btcStakeDraft.feeAmount !== undefined) { | ||||||||
| setValue("feeAmount", btcStakeDraft.feeAmount, { | ||||||||
| shouldValidate: true, | ||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
| } else if ( | ||||||||
| stakingInfo?.defaultFeeRate !== undefined && | ||||||||
| (feeRate === undefined || feeRate === "") | ||||||||
|
Comment on lines
+63
to
+64
There was a problem hiding this comment. [nitpick] The condition
Suggested change
Copilot uses AI. Check for mistakes. |
||||||||
| ) { | ||||||||
| // Apply default only when no persisted draft and no current value | ||||||||
| setValue("feeRate", stakingInfo.defaultFeeRate.toString(), { | ||||||||
| shouldValidate: true, | ||||||||
| shouldDirty: false, | ||||||||
| shouldTouch: false, | ||||||||
| }); | ||||||||
| } | ||||||||
|
|
||||||||
| hasHydratedRef.current = true; | ||||||||
| }, [btcStakeDraft, stakingInfo?.defaultFeeRate, feeRate, setValue]); | ||||||||
|
|
||||||||
| const draft = useMemo( | ||||||||
| () => ({ | ||||||||
| finalityProviders, | ||||||||
| amount, | ||||||||
| term, | ||||||||
| feeRate, | ||||||||
| feeAmount, | ||||||||
| }), | ||||||||
| [finalityProviders, amount, term, feeRate, feeAmount], | ||||||||
| ); | ||||||||
|
|
||||||||
| // Persist on change | ||||||||
| useEffect(() => { | ||||||||
| setBtcStakeDraft(draft); | ||||||||
| }, [draft, setBtcStakeDraft]); | ||||||||
|
|
||||||||
| return null; | ||||||||
| } | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -22,9 +22,15 @@ interface FeeModalProps { | |||||||
| open?: boolean; | ||||||||
| onSubmit?: (value: number) => void; | ||||||||
| onClose?: () => void; | ||||||||
| currentFeeRate?: number; | ||||||||
| } | ||||||||
|
|
||||||||
| export function FeeModal({ | ||||||||
| open, | ||||||||
| onSubmit, | ||||||||
| onClose, | ||||||||
| currentFeeRate, | ||||||||
| }: FeeModalProps) { | ||||||||
| const [selectedValue, setSelectedValue] = useState(""); | ||||||||
| const [customFee, setCustomFee] = useState(""); | ||||||||
| const customFeeRef = useRef<HTMLInputElement>(null); | ||||||||
|
|
@@ -45,6 +51,32 @@ export function FeeModal({ open, onSubmit, onClose }: FeeModalProps) { | |||||||
| } | ||||||||
| }, [selectedValue]); | ||||||||
|
|
||||||||
| // Initialize selection based on current fee rate when opening | ||||||||
| useEffect(() => { | ||||||||
| if (!open || isLoading) return; | ||||||||
|
|
||||||||
| const fee = Number(currentFeeRate); | ||||||||
| if (!fee || !Number.isFinite(fee)) { | ||||||||
|
Comment on lines
+58
to
+59
There was a problem hiding this comment. The condition
Suggested change
Copilot uses AI. Check for mistakes. |
||||||||
| setSelectedValue(""); | ||||||||
| setCustomFee(""); | ||||||||
| return; | ||||||||
| } | ||||||||
|
|
||||||||
| if (fee === fastestFee) { | ||||||||
| setSelectedValue("fast"); | ||||||||
| setCustomFee(""); | ||||||||
| } else if (fee === mediumFee) { | ||||||||
| setSelectedValue("medium"); | ||||||||
| setCustomFee(""); | ||||||||
| } else if (fee === lowestFee) { | ||||||||
| setSelectedValue("slow"); | ||||||||
| setCustomFee(""); | ||||||||
| } else { | ||||||||
| setSelectedValue("custom"); | ||||||||
| setCustomFee(fee.toString()); | ||||||||
| } | ||||||||
| }, [open, isLoading, currentFeeRate, fastestFee, mediumFee, lowestFee]); | ||||||||
|
|
||||||||
| const feeOptions = [ | ||||||||
| { | ||||||||
| label: ( | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have comments on these values so it's easier to understand why, besides
Hydrate once on mount