Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Sep 4, 2025

Screenshot 2025-09-05 at 00 29 41

@jonybur jonybur marked this pull request as ready for review September 4, 2025 23:30
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 23:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds dark/light mode support for the three dots button by conditionally rendering different SVG icons based on the current theme. The implementation uses next-themes to detect the current theme and prevents hydration mismatches with a mounting state.

Key changes:

  • Imports two SVG assets for light and dark themes
  • Adds theme detection and mounting state management
  • Conditionally renders the appropriate icon based on the resolved theme

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@jeremy-babylonlabs jeremy-babylonlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not implement it like the other svg in core-ui?

jrwbabylonlab
jrwbabylonlab previously approved these changes Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants