Issue #146: Add Runserver Command #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 15, 2018 11:53
alexfinnarn
commented
Aug 16, 2018
|
|
||
| $items['backdrop-runserver'] = array( | ||
| 'description' => 'Runs PHP\'s built-in http server for development.', | ||
| 'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL, |
There was a problem hiding this comment.
probably need to change Drupal to Backdrop?
alexfinnarn
commented
Aug 16, 2018
| $extra = ' "' . __DIR__ . '/d7-rs-router.php"'; | ||
|
|
||
| // Start the server using 'php -S'. | ||
| $root = drush_get_context('DRUSH_SELECTED_DRUPAL_ROOT'); |
There was a problem hiding this comment.
same there; I don't know if "Drupal" needs to be changed but will try to look
alexfinnarn
commented
Aug 16, 2018
| // NOTE: The original runserver command had a way to log in a user and open a | ||
| // browser. Those have been removed from the Backdrop version of this command. | ||
|
|
||
| drush_print(dt('HTTP server listening on !addr, port !port (see http://!hostname:!port/!path), serving site !site!user...', array('!addr' => $addr, '!hostname' => $hostname, '!port' => $uri['port'], '!path' => $path, '!site' => drush_get_context('DRUSH_DRUPAL_SITE', 'default'), '!user' => $user_message))); |
There was a problem hiding this comment.
probably, but you'll need to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146. I ended up changing the namespace of the command by prepending "backdrop" and I think I got the runserver -> backdrop-runserver part as well.