-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #190: Port views drush commands #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create a directory /commands/views
and break each of these commands out into their own file per command so that there is less code per file and the code in each file is focused on the one commands logic.
* @file | ||
* Drush integration for Views. | ||
* | ||
* Useful commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this list is not exhaustive so maybe just leave it out.
function views_drush_help($section) { | ||
switch ($section) { | ||
case 'drush:views-revert': | ||
$help = dt('Reverts views in the drupal installation that have been overriden. '); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove references to Drupal or drupal
'aliases' => array('vr'), | ||
'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL, | ||
'callback' => 'views_revert_views', | ||
'drupal dependencies' => array('views'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we have an analagous backdrop_dependencies
for this, but in validation we can probably just check that views
is enabled.
$items['views-dev'] = array( | ||
'description' => 'Set the Views settings to more developer-oriented values.', | ||
'aliases' => array('vd'), | ||
'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a valid boostrap phase for Backdrop Drush Extension.
function views_development_settings() { | ||
state_set('views_ui_show_listing_filters', TRUE); | ||
state_set('views_ui_show_master_display', TRUE); | ||
state_set('views_ui_show_advanced_column', TRUE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these need to be config->set
's
cleaning up .... closing due to inactivity ... feel free to re-open if you resume work. |
#190