Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #190: Port views drush commands #191

Closed
wants to merge 1 commit into from

Conversation

klonos
Copy link
Member

@klonos klonos commented Jul 26, 2019

@klonos klonos requested a review from serundeputy July 26, 2019 16:24
Copy link
Member

@serundeputy serundeputy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a directory /commands/views and break each of these commands out into their own file per command so that there is less code per file and the code in each file is focused on the one commands logic.

* @file
* Drush integration for Views.
*
* Useful commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list is not exhaustive so maybe just leave it out.

function views_drush_help($section) {
switch ($section) {
case 'drush:views-revert':
$help = dt('Reverts views in the drupal installation that have been overriden. ');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove references to Drupal or drupal

'aliases' => array('vr'),
'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL,
'callback' => 'views_revert_views',
'drupal dependencies' => array('views'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we have an analagous backdrop_dependencies for this, but in validation we can probably just check that views is enabled.

$items['views-dev'] = array(
'description' => 'Set the Views settings to more developer-oriented values.',
'aliases' => array('vd'),
'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a valid boostrap phase for Backdrop Drush Extension.

function views_development_settings() {
state_set('views_ui_show_listing_filters', TRUE);
state_set('views_ui_show_master_display', TRUE);
state_set('views_ui_show_advanced_column', TRUE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be config->set's

@serundeputy
Copy link
Member

cleaning up .... closing due to inactivity ... feel free to re-open if you resume work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants