Skip to content
Coding standards

Issue #19: Select as Links should be within a list element #10

Sign in to view logs

Issue #19: Select as Links should be within a list element

Issue #19: Select as Links should be within a list element #10

Triggered via pull request March 1, 2024 22:44
@larynlaryn
synchronize #22
laryn:1.x-3.x-issue-19
Status Failure
Total duration 25s
Artifacts –

coding-standards.yml

on: pull_request
Run phpcs
17s
Run phpcs
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 3 warnings
Run phpcs: tests/better_exposed_filters.test#L566
Line exceeds maximum limit of 120 characters; contains 180 characters
Run phpcs
Line exceeds maximum limit of 120 characters; contains 180 characters
Run phpcs: tests/better_exposed_filters.test#L566
No space found before comment text; expected "// / $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-1"]/a[contains(@href, "?status_1=1")]', NULL, 'Correct link for "status: yes" filter');" but found "/// $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-1"]/a[contains(@href, "?status_1=1")]', NULL, 'Correct link for "status: yes" filter');"
Run phpcs
No space found before comment text; expected "// / $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-1"]/a[contains(@href, "?status_1=1")]', NULL, 'Correct link for "status: yes" filter');" but found "/// $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-1"]/a[contains(@href, "?status_1=1")]', NULL, 'Correct link for "status: yes" filter');"
Run phpcs: tests/better_exposed_filters.test#L567
Line exceeds maximum limit of 120 characters; contains 179 characters
Run phpcs
Line exceeds maximum limit of 120 characters; contains 179 characters
Run phpcs: tests/better_exposed_filters.test#L567
No space found before comment text; expected "// / $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-0"]/a[contains(@href, "?status_1=0")]', NULL, 'Correct link for "status: no" filter');" but found "/// $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-0"]/a[contains(@href, "?status_1=0")]', NULL, 'Correct link for "status: no" filter');"
Run phpcs
No space found before comment text; expected "// / $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-0"]/a[contains(@href, "?status_1=0")]', NULL, 'Correct link for "status: no" filter');" but found "/// $this->assertFieldByXpath('//div[@id="edit-status-1-wrapper"]//li[@id="edit-status-1-0"]/a[contains(@href, "?status_1=0")]', NULL, 'Correct link for "status: no" filter');"
Run phpcs: tests/better_exposed_filters.test#L567
Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
Run phpcs
Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
Run phpcs
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: thenabeel/action-phpcs@v8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run phpcs
The following actions uses node12 which is deprecated and will be forced to run on node16: thenabeel/action-phpcs@v8. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run phpcs: tests/better_exposed_filters.test#L567
There must be no blank line following an inline comment