[announcements] Migrate announcements plugin #1134
Open
+34,796
−17,211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kurt King <[email protected]>
Changed Packages
|
Signed-off-by: Kurt King <[email protected]>
kurtaking
force-pushed
the
announcements
branch
from
f6397c1
to
cfd2789
Compare
Signed-off-by: Kurt King <[email protected]>
Signed-off-by: Kurt King <[email protected]>
kurtaking
commented
Aug 30, 2024
Comment on lines
+8
to
+25
| "scripts": { | ||
| "dev": "concurrently \"yarn start\" \"yarn start-backend\"", | ||
| "start": "yarn workspace @backstage-community/plugin-announcements start", | ||
| "start-backend": "yarn workspace @backstage-community/plugin-announcements-backend start", | ||
| "start:ci": "concurrently \"yarn start\" \"yarn start-backend:ci\"", | ||
| "build": "backstage-cli repo build --all", | ||
| "tsc": "tsc", | ||
| "tsc:full": "tsc --skipLibCheck false --incremental false", | ||
| "new": "backstage-cli new --scope internal", | ||
| "clean": "backstage-cli repo clean", | ||
| "test": "backstage-cli repo test", | ||
| "test:all": "backstage-cli repo test --coverage", | ||
| "lint": "backstage-cli repo lint --since origin/main", | ||
| "lint:all": "backstage-cli repo lint", | ||
| "version": "changeset version && yarn install && (git commit -am 'Update internal dependencies' || true)", | ||
| "release": "changeset publish", | ||
| "prepare": "husky install", | ||
| "postinstall": "husky install || true" |
There was a problem hiding this comment.
todo: do I need to rework these?
Signed-off-by: Kurt King <[email protected]>
|
I've thoroughly reviewed 53 files and skimmed another 30. It would be helpful to have an initial review. |
kurtaking
changed the title
|
Closing and reopening for the CI issue (we're working on that in #875) |
|
CI seems to be failing with on the |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)