-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(release_workspace): add additional checks and document workflow #1175
base: main
Are you sure you want to change the base?
Conversation
19e754b
to
9108c14
Compare
- Introduced logic to verify the branch name is valid for the workspace - Added handling for missing GitHub events in release checks - Introduced logic to set npm publish tag (latest or maintenance) - Added initial plugin maintainer guide for patching older release lines Signed-off-by: Beth Griggs <[email protected]>
9108c14
to
dc772bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running with this @BethGriggs, also for including docs, left two comments.
I don't know the release flow well, @benjdlambert any chance you can look at this one, please?
|
||
When patching an older release, follow the steps below to ensure the correct workflow is applied: | ||
|
||
1. Request a `workspace/${workspace}` branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does one request a branch?
- Apply the necessary patch fixes or security updates. | ||
- Manually bump the version in `package.json` to reflect the new patch version (e.g., from `1.2.3` to `1.2.4`). | ||
|
||
4. Run the release workflow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we highlight what access you need to be able to run the workflow? This could go in a section towards the top. Pretty sure you need to be an Org Member 🤔
During the SIG today we discussed some various improvements and further prototyping needed here, I'll work on those |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
This is still needed, I just need to find time to update based on latest flow suggestions |
workspace/${workspace}
branch
input from the workflowHey, I just made a Pull Request!
✔️ Checklist
Signed-off-by
line in the message. (more info)